Add RHEL support to git feature - #782
Conversation
…os7, alma-{8,9}, alma-{8,9}-minimal
Fixes #1 Git feature passes all tests: existing + rhel-based base images: cent…
eljog
left a comment
eljog
left a comment
There was a problem hiding this comment.
Thank you for the PR. We really appreciate the time you have taken to contribute to the community.
- I have added a few comments
- Please accept the CLA
|
CLA has been submitted for review by our Legal team. I'm working to get it approved and signed as soon as possible. |
|
@microsoft-github-policy-service agree company="Analog Devices" |
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Thank you so much for taking the time in contributing this PR, we really appreciate it 🙌
This is going to be super helpful and useful for the community 🎉
Left some questions/comments, thanks again!
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Thanks for resolving my comments so quickly ✨
Added few more minor comments, thanks!
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
One more comment, thanks!
|
Samrhuddhi: Thank you for all the feedback and input. I think I've addressed all your inputs and requested changes and improvements. Please let me know if there is more I need to do. Thanks, Jeff. |
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Beautiful, thank you so much ✨ 🙏
|
Samrhuddhi: Thank you again for the thoughtful and helpful sugguestions. Jeff. |
|
@jdputschadi Let me know if you'd like to be added to the community slack channel. Instructions in https://github.com/orgs/devcontainers/discussions/3 |
3 participants
This PR adds RHEL support to git feature.
CentOS 7, RHEL/Alma/Rocky Linux 8 & 9 should all work. Testing was done with centos7, almalinux 8 and almalinux 9.
Includes ability to build feature on alma minimal base images.
resolves #781